Skip to content

src: mark realm leaf classes final#59355

Merged
addaleax merged 1 commit intonodejs:mainfrom
addaleax:realm-leafs
Aug 7, 2025
Merged

src: mark realm leaf classes final#59355
addaleax merged 1 commit intonodejs:mainfrom
addaleax:realm-leafs

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Aug 4, 2025

Since these classes use virtual methods extensively, adding final should allow compilers to optimize accesses better.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@legendecas legendecas legendecas approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax @nodejs-github-bot @mcollina @jasnell @legendecas @juanarbol @RaisinTen