Skip to content

fs: keep fs.promises.readFile read until EOF is reached#52178

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
kylo5aby:fs-readfile
May 11, 2024
Merged

fs: keep fs.promises.readFile read until EOF is reached#52178
nodejs-github-bot merged 1 commit intonodejs:mainfrom
kylo5aby:fs-readfile

Conversation

@kylo5aby
Copy link
Copy Markdown
Contributor

@kylo5aby kylo5aby commented Mar 21, 2024

  • For cases where the size==0 of the file to read, ensure it ends upon reaching EOF.

Fixes: #52155

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REG 18.10.0->18.11.0] fs.promises.readFile from stdin is broken for slow input

7 participants

@kylo5aby @H4ad @nodejs-github-bot @orgads @legendecas @BridgeAR @aduh95