Skip to content

fs: remove workaround for esm package#50907

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-workaround
Nov 27, 2023
Merged

fs: remove workaround for esm package#50907
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-workaround

Conversation

@anonrig

@anonrig anonrig commented Nov 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Removes a TODO left by @ronag

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 25, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55921/

@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55922/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 95b1989 into nodejs:main Nov 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in 95b1989

targos pushed a commit that referenced this pull request Dec 4, 2023
@anonrig @targos
fs: remove workaround for esm package
c1ee506 
PR-URL: #50907
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
This was referenced Dec 4, 2023
Merged
Closed
@ronag

ronag commented Dec 7, 2023

Copy link
Copy Markdown
Member

A little unsure why this was applied before standard-things/esm#821 was resolved?

@targos

targos commented Feb 15, 2024

Copy link
Copy Markdown
Member

@ronag The esm module was archived. It will never be resolved.

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@jeremymeng @marco-ippolito
Revert "fs: remove workaround for esm package"
f130a33 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue #51081

Backport-PR-URL: #51390
PR-URL: #50907
Fixes: #51081
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@MoLow MoLow MoLow approved these changes

@H4ad H4ad H4ad approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig @nodejs-github-bot @ronag @targos @lpinca @MoLow @H4ad