Skip to content

test, url: update WHATWG URL parser to align with latest spec #43190

Merged
aduh95 merged 5 commits intonodejs:mainfrom
F3n67u:update-wpt-url
Jun 30, 2022
Merged

test, url: update WHATWG URL parser to align with latest spec #43190
aduh95 merged 5 commits intonodejs:mainfrom
F3n67u:update-wpt-url

Conversation

@F3n67u
Copy link
Copy Markdown
Contributor

@F3n67u F3n67u commented May 23, 2022

The PR:

  1. update WPT test for url and resource to latest commit: automated by git node wpt
  2. remove test-whatwg-url-constructor.js, test-whatwg-url-origin.js, and test-whatwg-url-setters.js because they are now .any.js in the WPT upstream and covered by wpt test
  3. add isShadowRealm to global.GLOBAL to avoid wpt test crash: without this property test will fail with global.GLOBAL.isShadowRealm is not a function see https://github.com/web-platform-tests/wpt/blob/master/resources/testharness.js#L544
  4. update WHATWG URL parser to align with latest spec

Fix #42920
Fix #41717
Fix #42914: this issue is marked closed by #42915, but #42915 is reverted by #42940, so this issue is still not fixed

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

8 participants