test, url: update WHATWG URL parser to align with latest spec #43190
Merged
aduh95 merged 5 commits intonodejs:mainfrom Jun 30, 2022
Merged
test, url: update WHATWG URL parser to align with latest spec #43190aduh95 merged 5 commits intonodejs:mainfrom
aduh95 merged 5 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR:
git node wpttest-whatwg-url-constructor.js,test-whatwg-url-origin.js, andtest-whatwg-url-setters.jsbecause they are now .any.js in the WPT upstream and covered by wpt testisShadowRealmtoglobal.GLOBALto avoid wpt test crash: without this property test will fail withglobal.GLOBAL.isShadowRealm is not a functionsee https://github.com/web-platform-tests/wpt/blob/master/resources/testharness.js#L544Fix #42920
Fix #41717
Fix #42914: this issue is marked closed by #42915, but #42915 is reverted by #42940, so this issue is still not fixed