test: add NumberFormat resolvedOptions test#39401
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
test: add NumberFormat resolvedOptions test#39401richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test for NumberFormat resolvedOptions.
Refs: #39050
I'd like to land this on v14.x-staging together with/as part of #39051. We now have a CI job that builds Node.js dynamically linked against the minimum supported level of ICU but the job isn't failing on
v14.x-stagingfor the problem reported in #39050 as we don't have the coverage.