Skip to content

src: include uv.h in node_binding header#31265

Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:fix-uv-include
Closed

src: include uv.h in node_binding header#31265
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:fix-uv-include

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Jan 8, 2020 •
edited
Loading

This was removed in 3bb085d but is needed by Electron on Windows, as otherwise compilation errors will occur as a result of unknown libuv types:

In file included from ../../third_party/electron_node/src/node_binding.cc:1:
../../third_party/electron_node/src/node_binding.h(76,3): error: unknown type name 'uv_lib_t'
  uv_lib_t lib_;
  ^

See https://ci.appveyor.com/project/electron-bot/electron-ljo26/builds/29979721.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@codebytere codebytere requested a review from addaleax January 8, 2020 23:00
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 8, 2020
@codebytere
src: include uv.h in node_binding header
4d8ffe2 
This was removed in nodejs@3bb085d
but is needed by Electron on Windows, as otherwise compilation errors
will occur as a result of unknown libuv types.
@gengjiawen
Copy link
Copy Markdown
Member

gengjiawen commented Jan 9, 2020

Maybe add some comment to prevent from remove again ?

addaleax
addaleax approved these changes Jan 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although, just to be cٓlear, including this header is not officially supported anyway

bnoordhuis
bnoordhuis approved these changes Jan 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and frankly, I don't understand why our Windows build aren't failing... There's nothing that pulls in uv_lib_t, as far as I can determine.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28335/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 10, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28344/

codebytere added a commit that referenced this pull request Jan 10, 2020
@codebytere
src: include uv.h in node_binding header
a3d8de9 
This was removed in 3bb085d
but is needed by Electron on Windows, as otherwise compilation errors
will occur as a result of unknown libuv types.

PR-URL: #31265
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere
Copy link
Copy Markdown
Member Author

codebytere commented Jan 10, 2020

Landed in a3d8de9

@codebytere codebytere closed this Jan 10, 2020
@codebytere codebytere deleted the fix-uv-include branch January 10, 2020 23:04
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@codebytere @MylesBorins
src: include uv.h in node_binding header
06fbc03 
This was removed in 3bb085d
but is needed by Electron on Windows, as otherwise compilation errors
will occur as a result of unknown libuv types.

PR-URL: #31265
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere added a commit that referenced this pull request Mar 14, 2020