Conversation
addaleax
added
the
meta
AUTHORS
Outdated
There was a problem hiding this comment.
@uttampawar You have committed with two different email addresses – which do you prefer to have listed here?
AUTHORS
Outdated
There was a problem hiding this comment.
This is taken from the git log, from the Author: field – @Naturalclar Which name should we use here? Or should we keep the /?
AUTHORS
Outdated
There was a problem hiding this comment.
This was happening because we didn’t have support for .mailmap entries for Co-authored-by: or Author: tags that were manually added to the commit message.
8f2bb03609c3b4406f80dc4f71d91bdd27ac73f8 should remedy that.
AUTHORS
Outdated
There was a problem hiding this comment.
Back then I am young and simple, now I think my email address is silly 😭
There was a problem hiding this comment.
@gengjiawen You can always change it for new commits with git config --global user.email [email protected], and you can always choose one for the AUTHORS file if you want? :)
(Also, it’s not silly. 🙂)
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags.
| David Mark Clements <[email protected]> davidmarkclements <[email protected]> | ||
| David Mark Clements <[email protected]> | ||
| David Mark Clements <[email protected]> <[email protected]> | ||
| David Mark Clements <[email protected]> <[email protected]> |
There was a problem hiding this comment.
@davidmarkclements Just confirming, since you’ve been freshly listed with a third email address thanks to b1ef279 – the NearForm one is still the one you use for AUTHORS?
|
@cclauss, this issue log shows that I deleted your comment here: #26383 (comment):
I wanted to apologise for that, that comment deletion was not intentional, and I just recently noticed it. I don't remember deleting a comment here (on a purpose or not), it must have been accidental, most likely while I was commenting on this issue from my phone. Unfortunately, I do not have the means of restoring a deleted comment or checking what exactly was in that comment (GitHub does not provide that afaik). The only way that I know how it could be restored is if you re-post it from your side. I really hope that nothing was missed, but in any case — please feel free to restore that comment if you want to. Sorry again 😞 . |
Someone who receives email notifications of comments on this issue might have the content. |
|
this is what I have in mailbox matching to that day and time - the accidentally deleted comment, for the record: Subject: Re: [nodejs/node] doc: update AUTHORS list (#26383)
From: cclauss
To: nodejs/node, Subscribed
Date: 03/02/2019 07:13 PM
@cclauss commented on this pull request.
In .mailmap:
> @@ -72,6 +73,8 @@ Chew Choon Keat <[email protected]>
Chris Andrews <[email protected]> cpandrews8 <[email protected]>
Chris Johnson <[email protected]>
Chris Young <[email protected]> <[email protected]>
+Christian Clauss <[email protected]>
We can keep line 76 and delete line 77. |
addaleax
added
the
author ready
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#26383 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
14 participants
This was last updated in September, so I think it’s time. :)