test: remove extraneous report validation argument#25986
Merged
cjihrig merged 1 commit intonodejs:masterfrom Feb 9, 2019
Merged
test: remove extraneous report validation argument#25986cjihrig merged 1 commit intonodejs:masterfrom
cjihrig merged 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Feb 7, 2019
richardlau
approved these changes
Feb 7, 2019
Member
Just noting that |
lpinca
approved these changes
Feb 8, 2019
Contributor
Author
The second argument passed to validate() and validateContent() is not used for anything. PR-URL: nodejs#25986 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
The second argument passed to validate() and validateContent() is not used for anything. PR-URL: #25986 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second argument passed to
validate()andvalidateContent()is not used for anything.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes