Skip to content

lib,src: make constants not inherit from Object#10458

Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye:make-constants-inherit-from-null
Closed

lib,src: make constants not inherit from Object#10458
thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye:make-constants-inherit-from-null

Conversation

@thefourtheye
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye commented Dec 26, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

lib src test

Description of change

Make sure constants object and all the nested objects don't inherit
from Object.prototype but from null.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments

@targos targos targos left review comments

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mscdex mscdex Awaiting requested review from mscdex

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

+1 more reviewer

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. lib / src Issues and PRs related to general changes in the lib or src directory. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@thefourtheye @targos @mscdex @jasnell @addaleax @Fishrock123 @cjihrig @nodejs-github-bot