Skip to content

Windows Coverage GitHub workflow broken #63979

Description

@richardlau

https://github.com/nodejs/node/actions/workflows/coverage-windows.yml has started failing for main and v24.x-staging.

src\hdr_histogram.c(149,23): error : incompatible pointer types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type 'unsigned long *' [-Wincompatible-pointer-types] [D:\a\node\node\deps\histogram\histogram.vcxproj]

Previously this was treated as a warning:

src\hdr_histogram.c(149,23): warning : incompatible pointer types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type 'unsigned long *' [-Wincompatible-pointer-types] [D:\a\node\node\deps\histogram\histogram.vcxproj]

Failing runs:

Passing runs:

It looks like this might be because the GitHub Windows 2025 runners have newer versions of Visual Studio 2026:

Histogram warnings:

Visual Studio 2026 Developer Command Prompt v18.6.2

Histogram errors:

Visual Studio 2026 Developer Command Prompt v18.7.0

FWIW we're still running on VS 2022 in our Jenkins CI where we see the warnings.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions