quic: fix premature unref of endpoint when listening

jasnell · aduh95 · commit 9bc875e522c8 · 2026-05-23T00:05:41.000+02:00
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63267 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/src/quic/endpoint.cc b/src/quic/endpoint.cc
@@ -735,7 +735,9 @@ void Endpoint::RemoveSession(const CID& cid,
     }
   }
   if (primary_session_count_ > 0 && --primary_session_count_ == 0) {
-    udp_.Unref();
+    if (!is_listening()) {
+      udp_.Unref();
+    }
     session_manager().RemoveSession(cid);
     // The endpoint may be idle (no sessions, not listening). MaybeDestroy
     // handles both closing (immediate destroy) and idle timeout (start

Original file line number	Diff line number	Diff line change
`@@ -735,7 +735,9 @@ void Endpoint::RemoveSession(const CID& cid,`
`735`	`735`	`}`
`736`	`736`	`}`
`737`	`737`	`if (primary_session_count_ > 0 && --primary_session_count_ == 0) {`
`738`		`- udp_.Unref();`
	`738`	`+ if (!is_listening()) {`
	`739`	`+ udp_.Unref();`
	`740`	`+ }`
`739`	`741`	`session_manager().RemoveSession(cid);`
`740`	`742`	`// The endpoint may be idle (no sessions, not listening). MaybeDestroy`
`741`	`743`	`// handles both closing (immediate destroy) and idle timeout (start`