Skip to content

Commit 3436da1

Browse files
privatenumberjuanarbol
privatenumber
authored and
juanarbol
committed
util: preserve function names without source map names
Signed-off-by: Hiroki Osame <[email protected]> PR-URL: #65108 Fixes: #65104 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Signed-off-by: Juan José Arboleda <[email protected]>
1 parent 589a8d4 commit 3436da1

3 files changed

Lines changed: 10 additions & 2 deletions

File tree

‎lib/util.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -537,8 +537,7 @@ function reconstructCallSite(callSite) {
537537
if (!entry?.originalSource) return;
538538
return {
539539
__proto__: null,
540-
// If the name is not found, it is an empty string to match the behavior of `util.getCallSite()`
541-
functionName: entry.name ?? '',
540+
functionName: entry.name || callSite.functionName,
542541
scriptName: entry.originalSource,
543542
lineNumber: entry.originalLine + 1,
544543
column: entry.originalColumn + 1,

‎test/fixtures/source-map/get-call-sites-function-name-mapped.js‎

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/fixtures/source-map/get-call-sites-function-name-mapped.map‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"version": 3,
3+
"sources": ["get-call-sites-function-name-original.js"],
4+
"sourcesContent": ["const { getCallSites } = require('node:util'); function foo() { process.stdout.write(JSON.stringify(getCallSites({ sourceMap: true })[0])); } foo();"],
5+
"mappings": "AAAA,KAAM,CAAE,YAAa,EAAI,QAAQ,WAAW,EAAG,SAAS,KAAM,CAAE,QAAQ,OAAO,MAAM,KAAK,UAAU,aAAa,CAAE,UAAW,EAAK,CAAC,EAAE,CAAC,CAAC,CAAC,CAAG,CAAE,IAAI",
6+
"names": []
7+
}

0 commit comments

Comments
 (0)