src: replace uses of deprecated v8::External APIs

gahaas · aduh95 · commit 2dc1d205ee52 · 2026-05-05T16:19:54.000+02:00
PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/src/node_ffi.cc b/src/node_ffi.cc
@@ -191,7 +191,8 @@ MaybeLocal<Function> DynamicLibrary::CreateFunction(
 
   FFIFunctionInfo* info = new FFIFunctionInfo();
   info->fn = fn;
-  Local<External> data = External::New(isolate, info);
+  Local<External> data =
+      External::New(isolate, info, v8::kExternalPointerTypeTagDefault);
   MaybeLocal<Function> maybe_ret =
       Function::New(env->context(), DynamicLibrary::InvokeFunction, data);
   Local<Function> ret;
@@ -274,8 +275,8 @@ void DynamicLibrary::Close(const FunctionCallbackInfo<Value>& args) {
 
 void DynamicLibrary::InvokeFunction(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
-  FFIFunctionInfo* info =
-      static_cast<FFIFunctionInfo*>(args.Data().As<External>()->Value());
+  FFIFunctionInfo* info = static_cast<FFIFunctionInfo*>(
+      args.Data().As<External>()->Value(v8::kExternalPointerTypeTagDefault));
   FFIFunction* fn = info->fn.get();
 
   if (fn == nullptr || fn->closed || fn->ptr == nullptr) {
