This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Fix ABI breakage#503
Closed
bnoordhuis wants to merge 0 commit into
Closed
Conversation
sam-github
approved these changes
Mar 23, 2020
indutny
approved these changes
Mar 23, 2020
indutny
left a comment
indutny
left a comment
Member
There was a problem hiding this comment.
LGTM. Nice reuse of the fields!
|
This doesn't resolve the problem with |
Member
Author
|
Good call, I forgot to update that one. Done in a fix-up commit. |
bnoordhuis
added a commit
that referenced
this pull request
Mar 24, 2020
Fix ABI breakage introduced in commit 7d5c99d ("Support multi-coding Transfer-Encoding") by undoing the change in `sizeof(http_parser)`. Restore the size of the `flags` field and shrink the `index` field from 7 to 5 bits. It track strings up to `strlen("Transfer-Encoding")` bytes so 2^5 == 32 is wide enough. Fixes: #502 PR-URL: #503 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ABI breakage introduced in commit 7d5c99d ("Support multi-coding
Transfer-Encoding") by undoing the change in
sizeof(http_parser).Restore the size of the
flagsfield and shrink theindexfield from7 to 5 bits. It track strings up to
strlen("Transfer-Encoding")bytesin size so 2^5 == 32 is wide enough.
Fixes: #502