Remove GetRefValue#923
Merged
Merged
Conversation
Using `GetRefValue` would return the V8 handled pointer instead of the pointer to the libgit2 value and the V8 handled pointer could be changed at any moment. Removing this function and setting the pointer value to the underlying C object will prevent V8 GC screwing up a NodeGit app.
Collaborator
Author
|
@joshaber I want to get this in before another release. This is pretty big. |
Collaborator
|
That's fine, I'm in no rush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
GetRefValuewould return the V8 handled pointer instead of the pointer to the libgit2 value and the V8 handled pointer could be changed at any moment.Removing this function and setting the pointer value to the underlying C object will prevent V8 GC screwing up a NodeGit app.