Don't check for \\ No newline at end of file\n if it can't exist#908
Merged
Conversation
implausible
force-pushed
the
fix-segfault-convenient-patch
branch
2 times, most recently
from
044c9cf to
5d11745
Compare
implausible
force-pushed
the
fix-segfault-convenient-patch
branch
from
5d11745 to
59ecdf0
Compare
implausible
added a commit
that referenced
this pull request
Feb 18, 2016
Don't check for \\ No newline at end of file\n if it can't exist
Member
|
Magic number? Would it be possible to document that somewhere in the code? |
Collaborator
|
@implausible is it 29 because that's the length of this string? |
Member
|
That makes way more sense, at least we know it's not magic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If content isn't greater than 29, don't search for the no newline token. This lead to segfaults on linux. Interestingly, this did not affect most OSX and Windows machines. Some sort of compiler-saving-of-the-day?? No clue.