Skip to content

Attempt remove the delete keyword#534

Merged
tbranyen merged 2 commits into
masterfrom
remove-delete
Apr 20, 2015
Merged

Attempt remove the delete keyword#534
tbranyen merged 2 commits into
masterfrom
remove-delete

Conversation

@tbranyen
Copy link
Copy Markdown
Member

@tbranyen tbranyen commented Apr 9, 2015

Resolves #533

@tbranyen tbranyen mentioned this pull request Apr 9, 2015
Closed
@johnhaley81
Copy link
Copy Markdown
Collaborator

johnhaley81 commented Apr 17, 2015

Do we know why this is failing?

@tbranyen
Copy link
Copy Markdown
Member Author

tbranyen commented Apr 20, 2015

It was failing because normalizeOptions doesn't know to exclude remote_callbacks, I could have hardcoded it there, but I preferred to just take a shallow clone of the passed in options object as to not mutate the one passed.

tbranyen added a commit that referenced this pull request Apr 20, 2015
@tbranyen
Merge pull request #534 from nodegit/remove-delete
ef4d5e2 
Attempt remove the delete keyword
@tbranyen tbranyen merged commit ef4d5e2 into master Apr 20, 2015
@tbranyen tbranyen deleted the remove-delete branch April 20, 2015 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

options not reusable, nodegit destroys it

2 participants

@tbranyen @johnhaley81