Skip to content

Fix freeing a GitOid that was passed as a string #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 1 commit into from
Apr 7, 2015
Merged

Fix freeing a GitOid that was passed as a string #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate/templates/partials/sync_function.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ from_{{ arg.name }}
{%each args|argsInfo as arg %}
{%if arg | isOid %}
if (args[{{ arg.jsArg }}]->IsString()) {
free(&from_{{ arg.name }});
free((void *)from_{{ arg.name }});
}
{%endif%}
{%endeach%}
Expand Down
17 changes: 17 additions & 0 deletions test/tests/oid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
var assert = require("assert");
var path = require("path");
var local = path.join.bind(path, __dirname);

describe("Oid", function() {
var NodeGit = require("../../");
Expand Down Expand Up @@ -26,4 +28,19 @@ describe("Oid", function() {

assert.equal(inspect, "[Oid " + oid + "]");
});

it("can convert strings to oids in parameters", function() {
return NodeGit.Repository.open(local("../repos/workdir"))
.then(function(repo) {
var revwalk = repo.createRevWalk();
revwalk.sorting(NodeGit.Revwalk.SORT.TIME);

revwalk.push(oid);

return revwalk.getCommits(1);
})
.then(function(commits) {
assert.equal(commits[0].toString(), oid);
});
});
});