Skip to content

Converted from eio_custom to uv_queue_work#48

Merged
faceleg merged 5 commits into
nodegit:masterfrom
faceleg:master
Feb 27, 2013
Merged

Converted from eio_custom to uv_queue_work#48
faceleg merged 5 commits into
nodegit:masterfrom
faceleg:master

Conversation

@faceleg
Copy link
Copy Markdown
Collaborator

@faceleg faceleg commented Feb 26, 2013

Thus removing the warnings:

WARNING: ev_ref is deprecated, use uv_ref
WARNING: ev_unref is deprecated, use uv_unref

@tbranyen
Copy link
Copy Markdown
Member

Hey man are you interested in being a repo collaborator?

@faceleg
Copy link
Copy Markdown
Collaborator Author

faceleg commented Feb 26, 2013

@tbranyen yes I am 🎱 - I emailed you at [email protected] requesting exactly that a few hours ago.

@tbranyen
Copy link
Copy Markdown
Member

done, feel free to merge 👍

Comment thread example/convenience-commit.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be commented out again.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, will merge tonight (~12 hours from now)

@faceleg faceleg merged commit 5716e97 into nodegit:master Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants