Skip to content

Better cloning with NodeGit #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbranyen merged 4 commits into from
Mar 2, 2015
Merged

Better cloning with NodeGit #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efb2376
Convert Clone from object to function
tbranyen Mar 2, 2015
5773320
Test showing shorter clone syntax
tbranyen Mar 2, 2015
7061d68
Updated examples to show new syntax
tbranyen Mar 2, 2015
4c888f5
Remove only from describe block
tbranyen Mar 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var path = "/tmp/nodegit-clone-demo";
fse.remove(path).then(function() {
var entry;

nodegit.Clone.clone(
nodegit.Clone(
"https://github.com/nodegit/nodegit.git",
path,
{
Expand Down
2 changes: 1 addition & 1 deletion examples/cloneFromGithubWith2Factor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var opts = {
};

fse.remove(path).then(function() {
nodegit.Clone.clone(repoUrl, path, opts)
nodegit.Clone(repoUrl, path, opts)
.done(function(repo) {
if (repo instanceof nodegit.Repository) {
console.info("We cloned the repo!");
Expand Down
8 changes: 7 additions & 1 deletion lib/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,10 @@ Clone.clone = function(url, local_path, options) {
.then(openRepository);
};

module.exports = Clone;
// Inherit directly from the original clone object.
Clone.clone.__proto__ = Clone;

// Ensure we're using the correct prototype.
Clone.clone.prototype = Clone.prototype;

module.exports = Clone.clone;
16 changes: 8 additions & 8 deletions test/tests/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var local = path.join.bind(path, __dirname);

describe("Clone", function() {
var Repository = require(local("../../lib/repository"));
var Clone = require(local("../../lib/clone"));
var clone = require(local("../../lib/clone"));
var NodeGit = require(local("../../"));

var clonePath = local("../repos/clone");
Expand All @@ -29,7 +29,7 @@ describe("Clone", function() {
var test = this;
var url = "http://git.tbranyen.com/smart/site-content";

return Clone.clone(url, clonePath).then(function(repo) {
return clone(url, clonePath).then(function(repo) {
assert.ok(repo instanceof Repository);
test.repository = repo;
});
Expand All @@ -46,7 +46,7 @@ describe("Clone", function() {
}
};

return Clone.clone(url, clonePath, opts).then(function(repo) {
return clone(url, clonePath, opts).then(function(repo) {
assert.ok(repo instanceof Repository);
test.repository = repo;
});
Expand All @@ -66,7 +66,7 @@ describe("Clone", function() {
}
};

return Clone.clone(url, clonePath, opts).then(function(repo) {
return clone(url, clonePath, opts).then(function(repo) {
assert.ok(repo instanceof Repository);
test.repository = repo;
});
Expand All @@ -90,7 +90,7 @@ describe("Clone", function() {
}
};

return Clone.clone(url, clonePath, opts).then(function(repo) {
return clone(url, clonePath, opts).then(function(repo) {
assert.ok(repo instanceof Repository);
test.repository = repo;
});
Expand All @@ -107,7 +107,7 @@ describe("Clone", function() {
}
};

return Clone.clone(url, clonePath, opts).then(function(repo) {
return clone(url, clonePath, opts).then(function(repo) {
test.repository = repo;
assert.ok(repo instanceof Repository);
});
Expand All @@ -118,7 +118,7 @@ describe("Clone", function() {
var prefix = process.platform === "win32" ? "" : "file://";
var url = prefix + local("../repos/empty");

return Clone.clone(url, clonePath).then(function(repo) {
return clone(url, clonePath).then(function(repo) {
assert.ok(repo instanceof Repository);
test.repository = repo;
});
Expand All @@ -127,7 +127,7 @@ describe("Clone", function() {
it("will not segfault when accessing a url without username", function() {
var url = "https://github.com/nodegit/private";

return Clone.clone(url, clonePath, {
return clone(url, clonePath, {
remoteCallbacks: {
certificateCheck: function() {
return 1;
Expand Down