Update dependency fs-extra to ~0.14.0#343
Merged
Merged
Conversation
Collaborator
|
Thanks for bumping fs-extra :) |
johnhaley81
added a commit
that referenced
this pull request
Jan 13, 2015
Update dependency fs-extra to ~0.14.0
Contributor
Author
|
Thanks! |
Contributor
Author
|
FYI, cdnjs's git auto-updater(https://github.com/cdnjs/autoupdate) not work properly after fs-extra v0.12 (I meant v0.13/0.14), we should still be careful here(I'm not sure if the CI test covered 100% codes). |
Collaborator
|
The only thing we actually use fs-extra for is generating the code on a platform that we don't already have a pre-built binary up on S3 and for running tests. So it's not actually used in production at all (hopefully) but just for dev. It should be moved into the dev dependancies but we had some problems in the past with doing that. We'll have to take a closer look at all of our dev dependancies after @maxkorp finishes some of our npm install script work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like nodegit works fine with fs-extra v0.14, would you like to merge this PR, thanks.