Added ability for callbacks to poll promises for fulfillment value#260
Conversation
|
This will need then/promise#58 to be fixed in order for it to work. If they refuse that pull request we might need to switch libraries. |
There was a problem hiding this comment.
We need to return Promises within the tests
|
We may want to consider using https://github.com/zenparsing/v8-promise instead. This will more closely model the construct we'll use once Node 0.12 lands. A note: we should also coerce all inbound Promises to this implementation using |
|
v8-promise doesn't have sync-polling of a promise however. :( |
johnhaley81
force-pushed
the
callback-promises
branch
from
6f23643 to
a7c91dc
Compare
johnhaley81
force-pushed
the
callback-promises
branch
2 times, most recently
from
e3c1df1 to
356bccc
Compare
|
We finally settled on forking then/promise into a new repo nodegit/promise and using that in promisify-node. |
|
This makes me wonder if we should keep promisify-node generic and fork it to nodegit as well? |
|
We can do that. Keep all of nodegit's stuff in this org. |
This should pass tests after then/promises#58 is fixed.
johnhaley81
force-pushed
the
callback-promises
branch
from
356bccc to
81c14b7
Compare
Added ability for callbacks to poll promises for fulfillment value
|
I still don't understand, why not to use the Bluebird-lib? |
|
This PR is superseded by #854 |
3 participants
This will allow a callback native to libgit2 to actually have a promise value be returned in the callback eventually. We'll be able to not pause the JS thread while we wait for authentication or any other callback that is triggered from the V8 side.