Generate nodegit from libgit2 docs and refactor descriptor#259
Merged
Conversation
Collaborator
|
Going to argue that we still want a types file, but that there should be a static tracked version, and the compiled version should be separate and untracked, rather than overwriting them together. |
johnhaley81
force-pushed
the
refactor-descriptor
branch
from
ae6352c to
f9c7a6b
Compare
maxkorp
force-pushed
the
refactor-descriptor
branch
from
0b24d8c to
c2911b3
Compare
Collaborator
Author
|
Currently, we are generating everything from the libgit2 docs and supplementing the docs if it's missing anything. The supplements should get phased out when libgit2 adds the missing stuff into their docs. We're also using descriptors.json as overrides to libgit2 docs. |
maxkorp
force-pushed
the
refactor-descriptor
branch
from
17f52b4 to
fe02a2b
Compare
This is just a commit to show the direction we're going to take with refactoring out descriptor. Very broken right now
maxkorp
force-pushed
the
refactor-descriptor
branch
from
fe02a2b to
ded20af
Compare
johnhaley81
changed the title
johnhaley81
added a commit
that referenced
this pull request
Nov 8, 2014
Generate nodegit from libgit2 docs and refactor descriptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native modules that are generated are compiled now from 3 sources: descriptor.json, types.json and the libgit2 docs json file. We only really need the libgit2 docs file and in rare cases have overrides in the descriptor.json file.
This should reduce a lot of the complexity in generating the native module.