Use same API for signingCb in all places that can be crypto signed#1621
Merged
implausible merged 2 commits intoFeb 5, 2019
Merged
Conversation
Any place where we implement a callback pattern for signing commits/tags follows the same API:
`type SigningCB = (content: string) => { code: number, field?: string, signedData?: string };`
implausible
force-pushed
the
fix/unify-signing-callback-apis
branch
from
79a87dd to
874e653
Compare
implausible
changed the title
emmax86
requested changes
Feb 5, 2019
emmax86
approved these changes
Feb 5, 2019
Contributor
|
FWIW I just verified the changes here in commit.js still lead to a verified commit signature in the github ui using repo.createCommitWithSignature(
'HEAD',
author,
committer,
commitMessage,
oid,
[parent],
'gpgsig',
onSignature
)
...
function onSignature(tosign) { ... }
|
Member
Author
|
@dabutvin Sorry to shift this around from underneath ya 😄. We are hoping to stabilize by release of v0.25.0. |
Contributor
|
no worries, the update to take the head parameter is a huge improvement for using this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any place where we implement a callback pattern for signing commits/tags follows the same API:
type SigningCB = (content: string) => { code: number, field?: string, signedData?: string };What still needs to be done: