Skip to content

Run submodule updates in sequence rather than parallel #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 2 commits into from
Oct 2, 2018
Merged

Run submodule updates in sequence rather than parallel #1558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc40888
Run submodule updates in sequence rather than parallel
implausible Oct 1, 2018
14b20e5
That linter though...
implausible Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions lifecycleScripts/submodules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,22 @@ module.exports = function submodules() {
console.warn("\nThey will not be updated.");
}

return Promise.all(statuses
return statuses
.filter(function(status) {
return !status.onNewCommit;
})
.map(function(submoduleToUpdate) {
console.log("[nodegit] Initializing submodules");

return exec(
"git submodule update --init --recursive " + submoduleToUpdate.name
);
})
);
.reduce(function(chainPromise, submoduleToUpdate) {
return chainPromise
.then(function() {
console.log(
"[nodegit] Initializing submodule",
submoduleToUpdate.name
);
return exec(
"git submodule update --init --recursive " +
submoduleToUpdate.name
);
});
}, Promise.resolve());
});
};