Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault#1368
Merged
Merged
Conversation
implausible
force-pushed
the
fix_large_buffer_crashes
branch
5 times, most recently
from
9a4a6d7 to
9febe5d
Compare
implausible
force-pushed
the
fix_large_buffer_crashes
branch
from
9febe5d to
658f5b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger buffers.
Also removed some special case logic in the async_functions template that would prevent proper buffer method generation, and then updated descriptors for methods that require proper buffer allocations to be "shouldAlloc": true