fix issue with re-require()'ing native modules#1354
Conversation
Discussion on why this change was required can be found in the following issues: jestjs/jest#3552 jestjs/jest#3550 nodejs/node#5016
|
What is the additional startup time load on this? |
|
@maxkorp ~3ms on my MacBook Pro: const start = performanceNow();
rawApi = _.cloneDeep(rawApi);
const end = performanceNow();
console.log(((end - start) / MILLISECONDS).toFixed(3), 'seconds');0.003 seconds
node --version
v7.10.0🍻 |
|
@maxkorp is this PR safe to merge? If so, any rough ETA on when it might land in a release? |
|
Are there any blockers, or reasons why this is not merged? Perhaps some tests are needed? |
|
I think the addition of a test for this would be grand. I'm looking through the related discussions on what drove this PR and see if we can make it land soon. |
|
@implausible I'd say existing test cases cover this minor tweak as well. So not sure what else can be tested here. Either way, let me know what you want tested and I'll try to add. Thanks! |
|
Jest tests of modules that require Do you have any idea where is the actual problem (NodeGit, Jest or Node)? |
Discussion on why this change was required can be found in the following issues:
jestjs/jest#3552
jestjs/jest#3550
nodejs/node#5016