Fix example by forcing backslashes with path.posix#1346
Merged
Conversation
Index's addByPath function does not accept backslashes. To ensure that forward slashes are used, path.posix is used to join paths together with a forward slash in a platform independent way. Signed-off-by: Remy Suen <[email protected]>
Collaborator
|
Thanks! Can you writer a little test for this one? |
Member
Author
|
@saper Sorry, I don't understand. What would be added to the test suite? |
Member
Author
|
Someone got hit by this again today. Can we get this merged in so that the example is fixed? @saper Could you describe what you meant by the addition of a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported in #1339 that an error will occur if you try to run the
examples/add-and-commit.jsexample on Windows.This is because
addByPathfrom ofIndexseems to only accept paths with forward slashes. Replacing thepath.joinwithpath.posix.joinwill resolve the problem.