BREAKING: Added blob methods and converted to async#1327
Merged
Conversation
Member
|
Rebase this on master, please. |
cjhoward92
force-pushed
the
feature/blob_methods
branch
from
78bd9ac to
e2e34c9
Compare
implausible
requested changes
Jul 29, 2017
| committer, | ||
| commitMessage, | ||
| treeOid, | ||
| [parent]); |
Member
There was a problem hiding this comment.
I noticed you have a preference for closing on the same line, can we update the style to open/close on new lines if it's necessary to add new lines?
Contributor
Author
There was a problem hiding this comment.
Yeah, I will run through my tests and make the changes on Monday.
cjhoward92
force-pushed
the
feature/blob_methods
branch
from
255e6d0 to
7165bfb
Compare
cjhoward92
changed the title
Member
|
Other than the bblobs this is looking good. |
cjhoward92
force-pushed
the
feature/blob_methods
branch
from
7165bfb to
cdfad45
Compare
implausible
approved these changes
Aug 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed more blob methods from libgit2. The methods are:
Also made the createFromBuffer and createFromWorkdir methods asynchronous.
This is a breaking change to the blob api. createFromBuffer and createFromWorkdir are now asynchronous and thus return promises. This is because we try to maintain a standard of having methods that touch the disk as async to prevent deadlocks. While createFromBuffer does not touch the disk, it has a similar api to the other
createFrom*methods and we thought it made sense to make it async.