Try requiring build/Debug/nodegit if build/Release/nodegit wasn't found.#108
Merged
Merged
Conversation
nkallen
added a commit
that referenced
this pull request
Oct 13, 2013
Try requiring build/Debug/nodegit if build/Release/nodegit wasn't found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just spent half an hour trying to figure out why nodegit couldn't require
build/Release/nodegit.node. Turns out I was running version of node that was built with./configure --debug, which for some reason makes node-gyp put the compiled binary in another directory,build/Debug/.This fix falls back to looking in the
Debugdirectory ifnodegit.nodecouldn't be found in theReleasedirectory.