Skip to content

Set oid.selfFreeing to true instead of "true"#1033

Merged
johnhaley81 merged 1 commit into
nodegit:masterfrom
smith-kyle:string-to-boolean
May 26, 2016
Merged

Set oid.selfFreeing to true instead of "true"#1033
johnhaley81 merged 1 commit into
nodegit:masterfrom
smith-kyle:string-to-boolean

Conversation

@smith-kyle
Copy link
Copy Markdown
Contributor

@smith-kyle smith-kyle commented May 12, 2016

Does not modify code generation since previously the string "true" evaluated to truthy

Set oid.selfFreeing to true instead of "true"
de21154 
Does not modify code generation since previously the string "true" evaluated to truthy
@tbranyen
Copy link
Copy Markdown
Member

tbranyen commented May 12, 2016

Ah okay good catch. This could have caused problems if we were using ===

@johnhaley81
Copy link
Copy Markdown
Collaborator

johnhaley81 commented May 26, 2016

Thanks @smith-kyle

@johnhaley81 johnhaley81 merged commit a86dc6f into nodegit:master May 26, 2016
@smith-kyle smith-kyle deleted the string-to-boolean branch October 14, 2016 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smith-kyle @tbranyen @johnhaley81