Skip to content

Japanese message catalog update of core nodes for 0.18#1579

Merged
knolleary merged 4 commits into
node-red:0.18from
node-red-hitachi:0.18-message-jp
Jan 25, 2018
Merged

Japanese message catalog update of core nodes for 0.18#1579
knolleary merged 4 commits into
node-red:0.18from
node-red-hitachi:0.18-message-jp

Conversation

@HiroyasuNishiyama

Copy link
Copy Markdown
Contributor

Before you hit that Submit button....

Please read our contribution guidelines
before submitting a pull-request.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

If you want to raise a pull-request with a new feature, or a refactoring
of existing code, it may well get rejected if it hasn't been discussed on
the mailing list or
slack team first.

Proposed changes

Japanese message catalog update of core nodes for 0.18.
(sorry for previous PR with mistake)

Checklist

Put an x in the boxes that apply

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary
knolleary merged commit d26fb02 into node-red:0.18 Jan 25, 2018
@coveralls

coveralls commented Jan 25, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 87.755% when pulling 3c8fc2f on node-red-hitachi:0.18-message-jp into af68383 on node-red:0.18.

@HiroyasuNishiyama
HiroyasuNishiyama deleted the 0.18-message-jp branch January 25, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants