decoding no longer fails when unrepresentable tag size is encountered - #10
Conversation
|
Hi, Thanks for you PR. |
|
I should really start using these unit tests. Just commented out the greater than max representable for now. All Matroska says is that an unknown element size should be represented by all 1's, so I can't imagine there would be a need to use more than 8 bytes. |
|
Were you wanting a new unit test for a sample livestream? I could probably make a Big Buck Bunny livestream sample. |
|
You could add a test that checks if the return value for readVint equals Have a look at the (bad named) readVint test function here: https://github.com/siphontv/node-ebml/blob/master/test/ebml.js#L7 |
|
Good call. Let me know if you want any other changes (or a more clever message). |
decoding no longer fails when unrepresentable tag size is encountered
|
👍 |
|
Sweet! Thanks for the merge. I'm pretty new to node. Do you have to update the version for npm? npm install doesn't include the changes. Maybe 0.2.1? |
|
Oh, right. Well. Since this is a change in the api 1.0.0 would be correct, wouldn't it? |
|
Okay, published to npm as [email protected] |
|
Should lines |
I'm not sure if an unknown element size is only encountered with Matroska livestreams, but this made webm livestreaming possible for me. I'd like to use node-ebml as a dependency rather than forking it. Instead of throwing an error when encountering an unrepresentable tag size, the end should be treated as unknown.
Fix to issue #8.