fix: track invoked runs in isBusy()/getStatus() and noOverlap#612
Open
sarmah-rup wants to merge 1 commit into
Open
fix: track invoked runs in isBusy()/getStatus() and noOverlap#612sarmah-rup wants to merge 1 commit into
sarmah-rup wants to merge 1 commit into
Conversation
Member
|
hello @sarmah-rup thank for the PR, holding on it because the behavior was intentional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getStatus()/isBusy()don't account for runs started viaexecute().The state machine only flipped to
runningwhenexecution.reason === 'scheduled',so a manually invoked run (reason
'invoked') stayed invisible:getStatus()reported
idleandisBusy()returnedfalsemid-run.noOverlaprelies onthe same state, so it couldn't protect invoked runs either.
Fix
Drop the
reason === 'scheduled'guard in thebeforeRunandonFinishedhooks so every run flips
running->idle, matching the already-unconditionalonErrorhook.changeStateremains guarded byrunner.isStarted(), so anexecute()on an unstarted task is still a no-op. The idle/running transitionsare already permitted by the state machine.
Tests
Added a regression test in
introspection.test.tsthat gates an async handler,invokes
execute()without awaiting, waits forexecution:started, and assertsisBusy() === trueandgetStatus() === 'running'. It fails on the currentcode and passes with the fix. Full suite green with 100% coverage.
Closes #611