fix(release-please): match existing v-prefixed tags#575
Merged
Conversation
The repo's release tags are `vX.Y.Z`, but release-type `node` defaults to component-prefixed tags (`node-cron-vX.Y.Z`). release-please could not find its `v4.5.0` baseline, walked the whole history and proposed a bogus 5.0.0 release (PR #574). Set `include-component-in-tag: false` so it tracks the `vX.Y.Z` tags. Also drop the manual [Unreleased] section, redundant now.
merencia
force-pushed
the
fix/release-please-tag-format
branch
from
June 22, 2026 19:26
8725670 to
05a6b7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the misconfiguration from #572 that made release-please open a bogus 5.0.0 release PR (#574).
Root cause
The repo's tags are
vX.Y.Z(e.g.v4.5.0). Butrelease-type: nodedefaults to component-prefixed tags (node-cron-vX.Y.Z), so release-please looked fornode-cron-v4.5.0, did not find it, assumed there was no prior release, walked the entire history, and proposed5.0.0from already-shipped changes (#551, #548).Fix
"include-component-in-tag": false(+ explicit"include-v-in-tag": true) so it tracks the existingvX.Y.Ztags withv4.5.0as the baseline.## [Unreleased]section (and its link ref): with release-please the pending changes live in the open release PR.The
on: pushtrigger is intentional and kept: the release PR is a rolling preview that updates on each merge to main, and is only released when you merge it.After merge
Merging this pushes to main and re-runs release-please with the fixed config. It should update #574 down to a
4.6.0minor (only thefeatfrom #570 sincev4.5.0), not5.0.0. If it does not update cleanly, close #574 and it will be recreated on the next push to main.