Skip to content

fix(release-please): match existing v-prefixed tags#575

Merged
merencia merged 1 commit into
mainfrom
fix/release-please-tag-format
Jun 22, 2026
Merged

fix(release-please): match existing v-prefixed tags#575
merencia merged 1 commit into
mainfrom
fix/release-please-tag-format

Conversation

@merencia

@merencia merencia commented Jun 22, 2026

Copy link
Copy Markdown
Member

Fixes the misconfiguration from #572 that made release-please open a bogus 5.0.0 release PR (#574).

Root cause

The repo's tags are vX.Y.Z (e.g. v4.5.0). But release-type: node defaults to component-prefixed tags (node-cron-vX.Y.Z), so release-please looked for node-cron-v4.5.0, did not find it, assumed there was no prior release, walked the entire history, and proposed 5.0.0 from already-shipped changes (#551, #548).

Fix

  • "include-component-in-tag": false (+ explicit "include-v-in-tag": true) so it tracks the existing vX.Y.Z tags with v4.5.0 as the baseline.
  • Dropped the manual ## [Unreleased] section (and its link ref): with release-please the pending changes live in the open release PR.

The on: push trigger is intentional and kept: the release PR is a rolling preview that updates on each merge to main, and is only released when you merge it.

After merge

Merging this pushes to main and re-runs release-please with the fixed config. It should update #574 down to a 4.6.0 minor (only the feat from #570 since v4.5.0), not 5.0.0. If it does not update cleanly, close #574 and it will be recreated on the next push to main.

The repo's release tags are `vX.Y.Z`, but release-type `node` defaults to
component-prefixed tags (`node-cron-vX.Y.Z`). release-please could not find
its `v4.5.0` baseline, walked the whole history and proposed a bogus 5.0.0
release (PR #574). Set `include-component-in-tag: false` so it tracks the
`vX.Y.Z` tags. Also drop the manual [Unreleased] section, redundant now.
@merencia merencia changed the title fix(release-please): match existing v-prefixed tags fix(release-please): match v-tags and run manually Jun 22, 2026
@merencia
merencia force-pushed the fix/release-please-tag-format branch from 8725670 to 05a6b7d Compare June 22, 2026 19:26
@merencia merencia changed the title fix(release-please): match v-tags and run manually fix(release-please): match existing v-prefixed tags Jun 22, 2026
@merencia
merencia merged commit e43c152 into main Jun 22, 2026
11 checks passed
@merencia
merencia deleted the fix/release-please-tag-format branch June 22, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant