This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Refactorization, socket replacement#1
Merged
Conversation
nikdoof
added a commit
that referenced
this pull request
Jun 5, 2011
Refactorization, socket replacement
Owner
|
Looking good, most of the stuff I was looking to do but never had time to do :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your great job. Your library is exactly (almost ;)) what I was looking!
I was just looking for some good python class for working with TS3 Server Query and I liked this one, but I had some problems with it. First of all, I couldn't even connect to the server, had some problems with reading the server response so instead of fixing it I thought it would be better to replace sockets with a telnetlib library instead of playing with raw sockets.
I did also some code refactoring and what is important, I changed also behaviour of
send_commandmethod. I wanted it to return me the whole server response and I think that it should work like this from the first beginning. I wrapped it inTS3Responseclass and we may more methods to it to make it easier to work with the response data.TS3Response.responseholds now status of the server queryTS3Response.dataholds any extra data that was sent by the server - for example search result