Fix undefined node array key, using folder instead#1783
Merged
solracsf merged 1 commit intonextcloud:mainfrom Mar 28, 2026
Merged
Fix undefined node array key, using folder instead#1783solracsf merged 1 commit intonextcloud:mainfrom
solracsf merged 1 commit intonextcloud:mainfrom
Conversation
Signed-off-by: Simounet <[email protected]>
Simounet
force-pushed
the
fix/undefined-node-array-key
branch
from
f35b305 to
3ba71e1
Compare
DerDreschner
approved these changes
Mar 22, 2026
DerDreschner
left a comment
DerDreschner
left a comment
There was a problem hiding this comment.
Tested on Nextcloud 33.0.0 with PHP 8.5 and fixes the issue!
|
I also was dealing with this recently. And tested it on Ubuntu 22.04 Nextcloud 32.0.6 php8.3. This change fixes: |
Member
|
@CarlSchwan regression from #1614 |
solracsf
approved these changes
Mar 26, 2026
solracsf
added
bug
This was referenced Mar 28, 2026
|
patched my nc-33.0.1, seems to quiet it down, thanks |
|
When will this be released? |
|
has this change been pushed to the latest release channel yet? |
|
@SwellEquation Doesn't look like:
|
|
You can look at the merge commit (1e3dd4f) and under the commit message you can see all branches and tags containing the commit. Right now, it is only in the master branch, so no tags, and therefore not in any release. |
Contributor
|
I'll get this released this week, sorry for the delay! |
Contributor
|
I just released v5.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
It fixes the error on
/apps/notes/notesAPI calls:Because it's the
folderkey that's defined in SettingsService.php instead ofnode.Have a nice day.
Fixes #1784