fix(files): Apply HTML escaping to all user-controlled input before сoncatenating it into HTML#1768
Merged
max-nextcloud merged 1 commit intomainfrom Mar 13, 2026
Conversation
JuliaKirschenheuter
force-pushed
the
fix/Stored-HTML-Injection-in-Nextcloud-Notes-Markdown-Preview-via-Unescaped-Image-Alt-Text
branch
from
eb1126b to
d9b580a
Compare
JuliaKirschenheuter
force-pushed
the
fix/Stored-HTML-Injection-in-Nextcloud-Notes-Markdown-Preview-via-Unescaped-Image-Alt-Text
branch
2 times, most recently
from
fd6c343 to
7597609
Compare
benjaminfrueh
approved these changes
Mar 5, 2026
max-nextcloud
approved these changes
Mar 11, 2026
…oncatenating it into HTML Signed-off-by: julia.kirschenheuter <[email protected]>
max-nextcloud
force-pushed
the
fix/Stored-HTML-Injection-in-Nextcloud-Notes-Markdown-Preview-via-Unescaped-Image-Alt-Text
branch
from
7597609 to
d90875b
Compare
max-nextcloud
deleted the
fix/Stored-HTML-Injection-in-Nextcloud-Notes-Markdown-Preview-via-Unescaped-Image-Alt-Text
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: Stored HTML Injection in Nextcloud Notes Markdown Preview via Unescaped Image Alt Text
To be done:
Done:
Apply HTML escaping to all user-controlled input before concatenating it into HTML