fix(filesplugin): file actions invisible on NC33+ (registry mismatch, #848)#855
Draft
oleksandr-nc wants to merge 2 commits intomainfrom
Draft
fix(filesplugin): file actions invisible on NC33+ (registry mismatch, #848)#855oleksandr-nc wants to merge 2 commits intomainfrom
oleksandr-nc wants to merge 2 commits intomainfrom
Conversation
oleksandr-nc
force-pushed
the
fix/848-fileaction-registry-mismatch
branch
5 times, most recently
from
0310687 to
fa43b5d
Compare
Signed-off-by: Oleksander Piskun <[email protected]>
oleksandr-nc
force-pushed
the
fix/848-fileaction-registry-mismatch
branch
from
fa43b5d to
9aae687
Compare
Signed-off-by: Oleksander Piskun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #848.
AppAPI bundles
@nextcloud/[email protected], which still uses the legacywindow._nc_fileactionsarray, while NC33+ ships@nextcloud/[email protected]and reads from the new versioned scoped registry atwindow._nc_files_scope.v4_0.fileActions- so file actions registered by ExApps land in a registry the Files app never reads, and never become visible.