feat: Add enum and default value support in task processing#359
feat: Add enum and default value support in task processing#359
Conversation
There was a problem hiding this comment.
We have time to change this, since NC30 is not published yet - let's make everything simple and clear in AppAPI too.
I propose to transmit/receive everything in the structure that Anupam introduced(array $provider), without duplicating the same information in POST parameters as separate variables.
$name, $displayName, $taskType at leat should be removed as a parameters, maybe $customTaskType too.
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
feat/enum-task-processing
branch
from
29069a1 to
8b72752
Compare
All related PRs: #284 nextcloud/app_api#359 nextcloud/translate2#11 --------- Signed-off-by: Anupam Kumar <[email protected]> Signed-off-by: Alexander Piskun <[email protected]> Co-authored-by: Alexander Piskun <[email protected]>
There was a problem hiding this comment.
I'd published nc_py_api
@marcelklehr will you have time to test this tommorow?
Anupam told me that he tested and it was working, from my point of view all is looking fine.
But as I understand this all is a breaking change in API and we need to publish all ExApp related to this in one day(or at least make commit to not break "Daily").
Yep will do |
Right. Personally, I'm ok if AI on daily doesn't work for a bit, but if we can avoid it that'd be good. That would be app_api 4.0.0 then? Affected ex apps apps of mine is only llm2, I think |
|
Tested and works with llm2 |
4 participants
All related PRs:
cloud-py-api/nc_py_api#284
#359
nextcloud/translate2#11