Add ordering after data normalization.#112
Merged
pszulczewski merged 2 commits intodevelopfrom Jan 24, 2024
Merged
Conversation
pszulczewski
requested review from
chadell,
jeffkala,
lvrfrc87 and
scetron
as code owners
lvrfrc87
previously approved these changes
Jan 22, 2024
Collaborator
lvrfrc87
left a comment
lvrfrc87
left a comment
There was a problem hiding this comment.
LGTM! Thanks for raising this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some device commands elements may come in different order between pre and post check, especially when a device is rebooted after SW upgrade. This behavior was observed for
show lldp neighborswhen the order is different after reload what leads to failed post-check.This PR adds key sorting when data normalization is used with key anchoring.
Tests have been extended to cover that LLDP case with different order of neighbors between pre and post checks.
Updates in
test_operators.pyjust change the order of elements in expected results.