feat: expose RackReservation.user + minimal User#98
Draft
leoparente wants to merge 1 commit into
Draft
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
Regenerated from the updated ingester proto: RackReservation now exposes the required user field and a minimal User wrapper (username). Closes #75. Co-Authored-By: Claude Fable 5 <[email protected]>
6700e5b to
5e89cbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RackReservationnow exposes its requireduserfield, backed by a minimalUsertype (username only). Previously the wrapper had no way to set the user,so rack reservations failed ingestion with
Field user is required. Closes #75.What changes
ingester_pb2.py/.pyi) and theingesterwrapper from the updated proto.RackReservationgains auserfield; new minimalUserwrapper (username).docs/examples/rack_reservation.py(showsuser=User(username=...)).Usage
The user is a reference to an existing NetBox user (matched by username); it is
not created by ingest.
Notes