Repository navigation
Fix crash on fetching lyrics - #662
Open
cornelius-sevald wants to merge 1 commit into
Open
cornelius-sevald wants to merge 1 commit into
cornelius-sevald wants to merge 1 commit into
Conversation
Fixes ncmpcpp#649 Changes the inner type of the `m_worker` future from `boost::optional` to `LyricsFetcher::Result` (i.e. a `std::pair`). For some reason, calling `get()` on a future optional value will crash if the value is `none`, so I use the more primitive pair instead.
Contributor
|
Can you confirm that the bug is fixed with the last master and close this PR if yes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649
Changes the inner type of the
m_workerfuture fromboost::optionaltoLyricsFetcher::Result(i.e. astd::pair).For some reason, calling
get()on a future optional value will crash if the value isnone, so I use the more primitivestd::pairwith a boolean flag instead (likeLyricsFetcherdoes).NOTE: I'm really not very proficient at C++, and it's not a very clean fix, so feel free to disregard.