Repository navigation
Conversation
lyricsFilename joined the raw MPD song URI with mpd_music_dir in the store_lyrics_in_song_dir branch without filtering '..' components or absolute paths. Song::getURI returns mpd_song_get_uri verbatim and Song::isStream only rejects http(s):// prefixes, so a non-stream URI such as ../../home/user/.config/foo reached std::ofstream and wrote fetched lyrics content to an attacker-chosen path outside the music directory (with a forced .txt suffix). Strip '.' and '..' components and leading separators from the URI before joining so the resulting path stays confined under mpd_music_dir. This mirrors the sibling lyrics_directory branch, which already calls removeInvalidCharsFromFilename to strip '/'.
acts-1631
force-pushed
the
fix/path-traversal
branch
from
September 23, 2026 19:24
c3cb9c2 to
cd25795
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lyricsFilename joined the raw MPD song URI with mpd_music_dir in the
store_lyrics_in_song_dir branch without filtering '..' components or
absolute paths. Song::getURI returns mpd_song_get_uri verbatim and
Song::isStream only rejects http(s):// prefixes, so a non-stream URI
such as ../../home/user/.config/foo reached std::ofstream and wrote
fetched lyrics content to an attacker-chosen path outside the music
directory (with a forced .txt suffix).
Strip '.' and '..' components and leading separators from the URI
before joining so the resulting path stays confined under mpd_music_dir.
This mirrors the sibling lyrics_directory branch, which already calls
removeInvalidCharsFromFilename to strip '/'.