Repository navigation
Fix crash in TinyTagEditor::runAction() with files without extensions - #652
Merged
Merged
Conversation
Collaborator
|
Thanks :) |
kda
pushed a commit
to kda/ncmpcpp
that referenced
this pull request
Sep 8, 2026
…ncmpcpp#652) Co-authored-by: Devon Kirk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user opens the Tiny Tag Editor for a song without a file extension and selects the "Filename" option (option 20), ncmpcpp crashes.
The issue occurs in the code that splits the filename into a base name and extension:
If the filename doesn't contain a '.',
rfind(".")returnsstd::string::npos, and callingsubstr(npos)throwsstd::out_of_range, causing the crash. This affects files without extensions and stream URIs.The fix checks if
dot != std::string::nposbefore attempting to extract the extension: