Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Xilinx/SDAccel_Examples
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nacl/SDAccel_Examples
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jun 18, 2018

  1. Fix AES implementation; code cleanup. 

    The original implementation of the AES cipher assumed that the state matrix is
in row-major order, as C arrays are.  It is actually in column-major order, see:

  https://en.wikipedia.org/wiki/Advanced_Encryption_Standard#Description_of_the_cipher

Thus, all operations must operate on a transposed matrix: all steps that operate
on rows (i.e. ShiftRows) will need to operate on columns, and vice versa.  This
is implemented in both the encryption and decryption application.

Code cleanup was also done on the AES implementation, mostly in the form of the
addition of whitespace.  All C++ compilation warnings are resolved when using
the compilers provided with SDx.  The decrypt kernel code was modified slightly
in the Inverse MixColumns step to reduce the amount of code.  As it is written,
it should still have the same properties as the original implementation.

This was tested in the SDx software emulator on CentOS, and all tests passed.
Data rates when deployed KCU1500 card were approximately 3.25 GB/s.
    @nacl
    nacl committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    3afa389 View commit details
    Browse the repository at this point in the history
Loading