refactor(iotdb): migrate meta APIs to the unified db-* endpoints - #2235
Open
710leo wants to merge 1 commit into
Open
refactor(iotdb): migrate meta APIs to the unified db-* endpoints#2235710leo wants to merge 1 commit into
710leo wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughIoTDB schema loading now uses fixed database API routes and query-based request payloads. Column metadata uses ChangesIoTDB schema loading
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point the IoTDB metadata lookups at the shared
db-*endpoints instead of the cate-templatediotdb-*ones./api/n9e/{cate}-databases→/api/n9e/db-databases/api/n9e/{cate}-tables→/api/n9e/db-tables, payloaddb: string→query: string[]/api/n9e/{cate}-columns→/api/n9e/db-desc-table, payload{ db, table }→query: { database, table }[], response fieldname→field(sizedropped)getDatasourceCatehelper and theDatasourceCateEnumimport.Backend contract — checked against ccfos/nightingale main
center/router/router.goregistersdb-databases/db-tables/db-desc-tablemodels.QueryParam.Queries []interface{}is taggedjson:"query"ShowTablesf.Queries[0].(string)→ matchesquery: [database]DescribeTablef.Queries[0]through → matchesquery: [{ database, table }]types.ColumnPropertyis{ field, type, type2?, indexable }— hencename→field, nosizedatasource/iotdb/iotdb.goimplementsShowDatabases/ShowTables/DescribeTablegetDatabases/getTables/getColumnsinsrc/plugins/iotdb/services.tshave exactly one consumer —src/plugins/iotdb/components/Meta/index.tsx— updated in the same commit. No other plugin is touched.