feat(datasource): optimize datasource page - #2231

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/OnboardingProgress/PopoverContent.tsx`:
- Around line 55-61: Replace the dismissal <a> in the onDismiss rendering within
PopoverContent with a button using type="button", preserving the existing
className, onDismiss handler, and translated label so the control is keyboard
accessible.

In `@src/components/OnboardingProgress/useOnboardingProgress.ts`:
- Around line 33-35: Update useOnboardingProgress to expose a separate dismissed
state derived from and restored by the DONE_DETECT marker, rather than treating
dismissal as datasource completion. Ensure dismiss() sets and persists this
state, and update OnboardingProgressBadge and other onboarding surfaces to hide
when dismissed is true, including when no datasource exists.
- Around line 111-114: Update the onboarding progress effect around the
ONBOARDING_DONE_KEY localStorage read to catch storage access errors, using the
same fallback pattern as dismiss() and the completion write. On failure,
continue with session-only detection and ensure probeOnboarding() still runs so
loading state is handled.

In `@src/components/TemplateMatch/ImportModal.tsx`:
- Around line 118-167: The importDashboards function must tolerate partial
createDashboard failures instead of aborting on the first rejection. Replace the
Promise.all flow with Promise.allSettled, associate each result with its
selected dashboard, mark fulfilled dashboards via setDashImported, and report
rejected or returned-error failures in the modal while preserving retryability
for unsuccessful items.
- Around line 255-266: Ensure the mounted ImportForm reflects later bgid changes
instead of relying on antd initialValues, which only apply on mount. Update the
ImportForm integration and its initialBgid handling so a bgid change either
remounts the form or resets the form before setting the replacement field
values, preserving existing behavior for other initial values.

In `@src/pages/builtInComponents/AlertRules/ImportForm.tsx`:
- Line 71: Replace the lodash `_.isArray` checks around `dataList` and the
additional occurrences near the corresponding parsed JSON handling with native
`Array.isArray` checks, preserving the existing narrowing and fallback behavior.
- Around line 167-186: Add rejection handling to the createRule promise in the
import submission flow, alongside its existing then callback. Show an
appropriate user-facing error through the established Modal or message pattern
and ensure the rejection is handled without disrupting the existing success and
per-rule failure behavior.

In `@src/pages/datasource/components/NextActionButton.tsx`:
- Around line 33-50: Update the rendering logic in NextActionButton so enabled
actions without a url are not treated as disabled or unsupported. Preserve the
existing linked-button behavior for enabled actions with a url, and ensure the
no-standalone-page case renders without the disabled tooltip/button path, using
the component’s established null or inline-rendering behavior.

In `@src/pages/datasource/components/NextStepModal.tsx`:
- Around line 264-282: Update the non-inspect title in NextStepModal’s title
rendering to use locale translation keys such as saved_title and updated_title,
passing cateLabel and name as interpolation values instead of hardcoding 「」
around name. Add the corresponding keys to each locale with that language’s
appropriate quotation marks, while preserving the existing saved-versus-updated
selection and inspect-mode title.

In `@src/pages/datasource/components/TableSource/index.tsx`:
- Around line 181-198: Add error handling to the enable branch in the status
update handler: ensure the promise returned by doUpdate and
updateDataSourceStatus surfaces failures through the existing user-facing error
mechanism, while preserving success messaging and refresh behavior. Keep the
disable confirmation flow unchanged.

In `@src/pages/datasource/Detail.tsx`:
- Around line 28-30: Update the action derivation in the component around
`actions` and `exploreAction` so `getNextActions(cate, data?.id, isPlus)` is
called only once. Derive `exploreAction` by finding the primary explore action
directly from the existing `actions` array, matching the approach used in
`NextStepModal.tsx`, and remove the redundant `getPrimaryExploreAction` call.

In `@src/pages/datasource/Form.tsx`:
- Around line 179-186: The NextStepModal component is missing the `disabled`
prop, which causes it to report a disabled datasource as "unreachable" instead
of "disabled" when the modal probes it. Add the `disabled` prop to the
NextStepModal invocation using the result object's status field, mirroring the
pattern used in TableSource/index.tsx with `disabled={guideRecord.status !==
'enabled'}`, so the modal receives the correct disabled state and does not
attempt verification on disabled datasources.

In `@src/pages/datasource/locale/zh_HK.ts`:
- Around line 131-142: Update the added zh_HK translation block, including the
entries around probing and lines 181–205, to use Traditional Hong Kong Chinese
consistently. Replace all Simplified glyphs with the established zh_HK
terminology, including 檢查, 意味著, 暫不支援, 這個, 內置, 瀏覽, 建立, 匯入/導入, 選, and 當前, while
preserving the existing translation keys and interpolation placeholders.

In `@src/pages/explorer/components/ProbeBanner/index.tsx`:
- Around line 64-69: Update the two Link components in ProbeBanner by appending
the guided-landing context query parameters to the to prop values. Modify the
Link to '/dashboards' and the Link to '/alert-rules' to include the query string
__from=ds_guide&data_source_id=${datasourceId} so that the GuideLandingBanner
and actionMap receive the expected parameters when users navigate to these
pages.

---

Nitpick comments:
In `@src/components/TemplateMatch/index.tsx`:
- Line 111: Update the className in the TemplateMatch component to remove the
hardcoded rgba shadow fallback and use the existing theme variable system from
variable.css as the sole shadow source. Preserve the current hover shadow
behavior while ensuring it follows dark and light themes.

In `@src/components/TemplateMatch/services.ts`:
- Around line 45-54: Update postTemplateMatch so the delayed retry occurs only
when doTemplateMatch rejects with the specific “client not ready” error;
propagate authorization failures, timeouts, and other rejection reasons
immediately. Inspect the rejection reason in the existing catch before
scheduling the setTimeout retry, preserving the current retry delay and result
handling for the eligible error.

In `@src/pages/builtInComponents/AlertRules/ImportForm.tsx`:
- Around line 38-41: Replace the any types on the shared props interface in
ImportForm with the corresponding types exported by CommonStateContext for
busiGroups, groupedDatasourceList, reloadGroupedDatasourceList, and
datasourceCateOptions. Keep the component Props explicitly declared as an
interface and preserve the existing shared contract for both hosts.

In `@src/pages/datasource/locale/zh_HK.ts`:
- Around line 124-180: Use the file’s existing `數據源` terminology consistently in
the newly added datasource-related translations, replacing `資料來源` in keys such
as `unreachable`, `guide_landing`, and the associated descriptions and actions
while preserving the surrounding Hong Kong Chinese wording.

In `@src/pages/explorer/Prometheus/index.tsx`:
- Around line 74-75: Update the datasource selection handler in the Prometheus
explorer to set probeBannerVisible to false whenever the datasource changes,
matching the existing takeover behavior in the query-change handler. Use the
visible probeBannerVisible state and datasource-change logic, while preserving
the initial __from === 'ds_verify' && panelIdx === 0 condition.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/datasource/utils/useDataProbe.ts`:
- Around line 133-139: Make the staleData metricCount semantics consistent with
the ProbeResult contract: update the branch checking probed.ts === undefined to
return the 24-hour metric count from the established seenMetrics collection,
matching the other staleData return path. Keep freshMetrics.length for states
whose count specifically represents the 5-minute window.

---

Outside diff comments:
In `@src/components/TemplateMatch/ImportModal.tsx`:
- Around line 121-180: Update importDashboards around the selected-item mapping
so JSON.parse failures are caught per dashboard instead of escaping the _.map
callback. Convert malformed payloads into the same per-item { payload, err }
failure shape used for createDashboard errors, allowing valid dashboards to
continue through Promise.all and appear in the existing failed-dashboard
Modal.error reporting.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/pages/datasource/utils/useDataProbe.ts`:
- Around line 172-179: Update the run callback in useDataProbe so invalid
datasourceId or pluginType inputs increment seq.current before returning,
invalidating any pending probe. Preserve the existing unsupported-plugin
handling and probing sequence behavior for valid inputs.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/OnboardingProgress/useOnboardingProgress.ts`:
- Line 88: Scope the onboarding completion marker to the authenticated user by
deriving ONBOARDING_DONE_KEY from profile.id. In
src/components/OnboardingProgress/useOnboardingProgress.ts lines 333-337, read
the user-scoped key only after the profile identifier is available; in lines
352-360 and 386-394, persist dismissal and automatic completion using that same
key.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/pages/builtInComponents/AlertRules/ImportForm.tsx`:
- Around line 176-195: Update the import submission flow around createRule to
track an in-flight request with pendingSubmit: set it before starting the
request, disable the submit button and show its loading state while true, and
release it in finally so the lock clears on both success and failure. Preserve
the existing success, error, and onSuccess behavior.

---

Nitpick comments:
In `@src/components/ModalHOC.tsx`:
- Line 45: Replace the any-based boundaries with explicit TypeScript contracts:
in src/components/ModalHOC.tsx lines 45-45, type render using T & ModalWrapProps
or a dedicated internal interface; in
src/pages/builtInComponents/AlertRules/ImportForm.tsx lines 35-42, define
explicit business-group, datasource-list, reload-function, and
datasource-category types; and in lines 154-159, parse imported JSON as unknown,
validate its shape, then map typed rule records before calling createRule.

In `@src/pages/builtInComponents/AlertRules/ImportForm.tsx`:
- Around line 239-241: Update the wrapper around DatasourceValueSelectV2 to
replace its inline display style with className={contextBound ? 'hidden' :
undefined}. Keep the wrapper mounted and preserve the existing Form.List
submission behavior.