feat: skill support auth scope - #2174

src/pages/aiConfig/skills/pages/AddModal.tsx (1)

26-33: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Handle asynchronous errors and clean up form state.

The form validation and API request lack error handling, which can lead to unhandled promise rejections if validation fails or the network errors out. Additionally, the modal form state is not explicitly cleaned up on unmount or cancellation. As per coding guidelines, async requests must include error handling, and temporary container components must explicitly clean up form data on unmount.

🛠 Proposed fix

-      onCancel={onCancel}
-      onOk={() => {
-        form.validateFields().then((values) => {
-          postItem(adjustSubmitValues({ ...values, private: resolveSubmitPrivate(values.private) })).then(() => {
-            onOk();
-          });
-        });
-      }}
+      destroyOnClose
+      onCancel={() => {
+        form.resetFields();
+        onCancel();
+      }}
+      onOk={async () => {
+        try {
+          const values = await form.validateFields();
+          await postItem(adjustSubmitValues({ ...values, private: resolveSubmitPrivate(values.private) }));
+          onOk();
+        } catch (error) {
+          console.error(error);
+        }
+      }}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/aiConfig/skills/pages/AddModal.tsx` around lines 26 - 33, Update
the AddModal submit flow around form.validateFields and postItem to handle
validation and request failures without unhandled promise rejections, using the
component’s established error-handling pattern. Also explicitly reset or destroy
the form state when the modal is cancelled and when the component unmounts,
using the existing onCancel lifecycle and form instance.

Source: Coding guidelines

src/pages/aiConfig/skills/pages/EditModal.tsx (1)

52-62: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Handle asynchronous errors in form validation and submission.

The form validation and API request lack error handling, which can lead to unhandled promise rejections if validation fails or the request errors out. As per coding guidelines, async requests must include error handling.

🛠 Proposed fix

-      onOk={() => {
-        if (id) {
-          form.validateFields().then((values) => {
-            // 非 admin 未挂载「可见范围」字段，validateFields 不含 private；其当前值已由
-            // setFieldsValue(data) 存进 form store，用 getFieldValue 取出沿用，避免编辑改变可见性。
-            putItem(id, adjustSubmitValues({ ...values, private: resolveSubmitPrivate(values.private, form.getFieldValue('private')) })).then(() => {
-              onOk();
-            });
-          });
-        }
-      }}
+      onOk={async () => {
+        if (id) {
+          try {
+            const values = await form.validateFields();
+            // 非 admin 未挂载「可见范围」字段，validateFields 不含 private；其当前值已由
+            // setFieldsValue(data) 存进 form store，用 getFieldValue 取出沿用，避免编辑改变可见性。
+            await putItem(id, adjustSubmitValues({ ...values, private: resolveSubmitPrivate(values.private, form.getFieldValue('private')) }));
+            onOk();
+          } catch (error) {
+            console.error(error);
+          }
+        }
+      }}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/aiConfig/skills/pages/EditModal.tsx` around lines 52 - 62, Update
the onOk handler in EditModal to handle rejections from both
form.validateFields() and putItem(), using the existing project error-handling
pattern to surface or log failures. Ensure validation errors do not trigger
submission or the success callback, and API failures do not leave unhandled
promise rejections.

Source: Coding guidelines