Skip to content

refactor: remove use_case and trigger_mode filters and columns - #2113

Merged
jsers merged 1 commit into
mainfrom
task/hide-workflow-purpose-trigger-f12723
May 25, 2026
Merged

refactor: remove use_case and trigger_mode filters and columns#2113
jsers merged 1 commit into
mainfrom
task/hide-workflow-purpose-trigger-f12723

Conversation

@710leo

@710leo 710leo commented May 25, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Refactor
    • Simplified the event pipeline list view by removing filter options and table columns for use case and trigger mode. The interface now features only the disabled status filter and search functionality, providing a more streamlined experience for managing event pipeline records.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3980c81c-48ab-42ff-9788-39855b8c9d2f

📥 Commits

Reviewing files that changed from the base of the PR and between b5a59c7 and aca943f.

📒 Files selected for processing (1)
  • src/pages/eventPipeline/pages/List/index.tsx
💤 Files with no reviewable changes (1)
  • src/pages/eventPipeline/pages/List/index.tsx

📝 Walkthrough

Walkthrough

This PR simplifies the event pipeline list page by removing use_case and trigger_mode as filter dimensions. The filter state type, dropdown controls, table columns, and row filtering logic that referenced these fields are all removed, leaving a streamlined interface with only the disabled filter and matching row display logic.

Changes

Event Pipeline List Simplification

Layer / File(s) Summary
Filter state and UI controls
src/pages/eventPipeline/pages/List/index.tsx
The filter state type removes the optional use_case and trigger_mode fields, and their corresponding Select dropdown controls are removed from the filter UI section, leaving only the disabled filter.
Table columns and row filtering logic
src/pages/eventPipeline/pages/List/index.tsx
The table column definitions no longer render use_case and trigger_mode columns, and the row filtering logic removes the matching conditions for those fields, retaining only search and disabled row filtering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Two dimensions fade away so clean,
Use case and trigger mode unseen,
The filter shrinks, the table too,
List pages lighter, simpler, true! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: removing use_case and trigger_mode filters and columns from the event pipeline list component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/hide-workflow-purpose-trigger-f12723

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@710leo

710leo commented May 25, 2026

Copy link
Copy Markdown
Member Author
image

@jsers
jsers merged commit 29a5aea into main May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants